Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
503 capacity_exhaustedwith a clear manual-retry message when the existing setup active-Job admission limit is reached, beforerunJobis called.500 internal_error, without forwarding raw provider exceptions or guessing that a provider failure means capacity exhaustion.Harbor boundary review
This is Harbor-HF authenticated admission and HF Job lifecycle error reporting, not Harbor execution behavior.
Checked at pinned Harbor
dcd0a7ac74b7bd417780d9cb27cd819c7ec82e4e:src/harbor/models/job/config.py: nativeJobConfig, trial/agent concurrency and validation remain authoritative and untouched.src/harbor/environments/hf_sandbox.py:HFSandboxEnvironment.startdelegates toSandbox.create; Harbor owns environment lifecycle within a trial, not this control-service setup admission rejection.Reviewed upstream history through
1f84b4c007788702d9d9b06cfada3c4840103693, including native config validation/dry-run changes in9a2e3b13and the pinned-to-head diff for these files. No upstream feature replaces this control-layer error mapping, so no pin change or upstream patch is needed. The existing public Harbor execution/configuration/output boundary remains unchanged; this PR adds no Harbor imports, persisted fields, mirrored configuration, parser, or execution logic.Validation
Existing/environmental blockers — no gates weakened
slophammer-py check . --baselinecannot run:slophammer-baseline.jsonis absent.scripts/check_mutation.pyis absent.No Python behavior changed. No image build/publication, deployment, new setup/benchmark Job, inference, credential transfer, configuration change, or remote runtime mutation was performed. Publication and merge are separate from this local validation.