Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft visibility PR; execution is intentionally disabled and this is not production-ready.
9fb49cb) into the feature branch without rewriting history.The old publication-engine-dependent result-submission UI is not carried forward. Its JobConfig-era submission/review flow remains to be reconciled. The Workbench editor now exposes native JSON configuration rather than retaining the old parallel recipe library. Historical Bucket records are not migrated or modified.
Harbor ownership review
Checked Harbor revision
dcd0a7ac74b7bd417780d9cb27cd819c7ec82e4e; fresh upstream main had no later commits:src/harbor/cli/agents.py: publicharbor agents list --jsonandharbor agents schema NAME --jsonown discovery/options.src/harbor/cli/jobs.pyandsrc/harbor/models/job/config.py: native JobConfig, install-only and CLI configuration.src/harbor/job.py: Harbor owns task resolution, locks, retry and resume. Removed the local execution wrapper instead of duplicating these behaviors.src/harbor/environments/hf_sandbox.py: currentSandbox.createintegration lacks the needed public ownership-label/namespace boundary. Its authentication requirement does not authorize forwarding the control credential.A future public Harbor CLI/platform integration and isolated credential boundary are prerequisites to execution. No local Harbor patch, upstream issue, or upstream PR is included. Per-user OAuth scopes, billing attribution and Jobs/inference delegation are deferred research; no forwarding or OAuth implementation is added.
Verification
Passed:
linux/amd64.Remaining red checks (not waived):
slophammer-py check . --baseline: required baseline file is absent.scripts/check_mutation.py --min-kill-rate 90: script is absent following upstream mutation-tooling retirement; it was not restored.No HF operational API call, deployment, Job, inference, resource creation, credential transfer, reset, migration, Run action, or result publication was performed. Feature branch only; do not merge this draft into main.