Skip to content
This repository was archived by the owner on Jan 17, 2026. It is now read-only.

Allow program to be run from outside its own directory + other updates - #56

Merged
hube12 merged 3 commits into
hube12:masterfrom
Nel-S:patch-1
Nov 2, 2024
Merged

Allow program to be run from outside its own directory + other updates#56
hube12 merged 3 commits into
hube12:masterfrom
Nel-S:patch-1

Conversation

@Nel-S

@Nel-S Nel-S commented Oct 11, 2024

Copy link
Copy Markdown
Contributor
  • Add the path used to open the program from to all relative paths, so program doesn't create new folders in a directory outside the one it's located within
  • Replace sys.exits with exception raising (see Improvements for programmatic usage #55)
  • Replace assertion (which can be compiled out) with unskippable test + exception
  • Tweak url['..._mappings'] code so correct exception is raised (Python stack trace when I run DecompilerMC with an older Minecraft version without client-mappings #50)
  • Standardize pathlib usage
  • Some code restructuring to reduce the amount of indentation
  • Add some typing
  • Grammar fixes in code outputs/errors + significantly copyedit Readme (but no new information was really added)
  • Add TODOs to main.py to mark areas for future improvement

Nel-S added 2 commits October 11, 2024 00:41
- Add the path used to open the program from to all relative paths, so program doesn't create new folders in a directory outside the one it's located within
- Replace sys.exits with exception raising (see #55)
- Replace assertion (which can be compiled out) with unskippable test + exception
- Tweak url['..._mappings'] code so correct exception is raised (#50)
- Standardize pathlib usage
- Some code restructuring to reduce the amount of indentation
- Add some typing
- Grammar fixes in code outputs/errors
- Add TODOs to mark areas for future improvement
@hube12

hube12 commented Oct 31, 2024

Copy link
Copy Markdown
Owner

This does look good to me, I will need to check that this can be run by double clicking and not exiting the windows without you being able to read the message (the main purpose of the press a key then sys.exit(1))

@hube12
hube12 merged commit 747d672 into hube12:master Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants