This repository was archived by the owner on Jan 17, 2026. It is now read-only.
Allow program to be run from outside its own directory + other updates - #56
Merged
Conversation
Nel-S
commented
Oct 11, 2024
Contributor
- Add the path used to open the program from to all relative paths, so program doesn't create new folders in a directory outside the one it's located within
- Replace sys.exits with exception raising (see Improvements for programmatic usage #55)
- Replace assertion (which can be compiled out) with unskippable test + exception
- Tweak url['..._mappings'] code so correct exception is raised (Python stack trace when I run DecompilerMC with an older Minecraft version without client-mappings #50)
- Standardize pathlib usage
- Some code restructuring to reduce the amount of indentation
- Add some typing
- Grammar fixes in code outputs/errors + significantly copyedit Readme (but no new information was really added)
- Add TODOs to main.py to mark areas for future improvement
- Add the path used to open the program from to all relative paths, so program doesn't create new folders in a directory outside the one it's located within - Replace sys.exits with exception raising (see #55) - Replace assertion (which can be compiled out) with unskippable test + exception - Tweak url['..._mappings'] code so correct exception is raised (#50) - Standardize pathlib usage - Some code restructuring to reduce the amount of indentation - Add some typing - Grammar fixes in code outputs/errors - Add TODOs to mark areas for future improvement
Owner
|
This does look good to me, I will need to check that this can be run by double clicking and not exiting the windows without you being able to read the message (the main purpose of the press a key then sys.exit(1)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.