bugfix/start_thread_pool_server undefined Setting error#7
Open
wuxiaoyi wants to merge 3 commits into
Open
Conversation
Owner
|
啥也没改啊，就打了个 Log |
Contributor
Author
|
原来的log写错了，没有Setting这变量，应该用config.thread_size |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
发现用NonblockingServer的时候有点问题，client端close链接之后，server端不会关闭链接（没回发Fin给客户端），导致服务端的大量TCP链接一直在CLOST_WAIT状态。改用ThreadPoolServer就没有这个问题。感觉应该是thrift这个gem的bug，还没时间仔细研究。
先把这个起ThreadPoolServer的bug改了吧。。