Move output.csv file open to the the main function and limit to rank 0#132
Open
jprorama wants to merge 3 commits into
Open
Move output.csv file open to the the main function and limit to rank 0#132jprorama wants to merge 3 commits into
jprorama wants to merge 3 commits into
Conversation
This avoids opening the file in all ranks, causing file open contention between ranks. Contention increases with rank count and stripe count. Proposed partial fix for hpc-io#131 for base write benchmarks.
jeanbez
requested changes
Jul 28, 2025
jeanbez
left a comment
jeanbez
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution! If we do move this, we need to make the same changes to all the other patterns that output a CSV.
jeanbez
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids opening the file in all ranks, causing file open contention between ranks. Contention increases with rank count and stripe count.
Proposed partial fix for #131 for base write benchmarks.