fix(util): map ambiguous UConverter charset aliases#31
Merged
Conversation
Map windows-1252 and tis620 to unambiguous ICU names so HordeString charset conversion does not emit PHP warnings.
ralflang
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windows-1252andtis620charset aliases to unambiguous ICU names forUConverterMotivation
HordeString::convertCharset()falls back toUConverterwhen iconv/mbstring fail. Common mail charset names such aswindows-1252trigger PHP warnings (Ambiguous encoding specified, using ibm-5348_P100-1997) because ICU accepts multiple converters for the same alias.Changes
CharacterSets::$uconverterMapwithwindows-1252→cp1252andtis620→windows-874-2000Test plan
vendor/bin/phpunit --bootstrap vendor/autoload.php vendor/horde/util/test/CharacterSetsTest.phpwindows-1252mail parts in production logs