zod-openapi: infer parent Variables in defineOpenAPIRoute#1880
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Sai Asish <saiasish.cnp@gmail.com>
🦋 Changeset detectedLatest commit: d37e8d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1880 +/- ##
=======================================
Coverage 92.00% 92.00%
=======================================
Files 115 115
Lines 3925 3925
Branches 1005 1005
=======================================
Hits 3611 3611
Misses 282 282
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The author should do the following, if applicable
yarn changesetat the top of this repo and push the changesetFixes #1879.
defineOpenAPIRoute'sHandlerFromRoute/HookFromRoutepreviously dropped the routemiddleware'sVariables, leavingc.var.*typed asany. They now use the sameR['middleware'] extends MiddlewareHandler[] | MiddlewareHandler ? RouteMiddlewareParams<R>['env'] & E : Epattern thatOpenAPIHono.openapi()already uses, and a new type test inhandler.test-d.tsasserts the inferred handler env carries the middleware'sVariables.