fix(zod-openapi): inherit defaultHook from parent app on nested routes#1878
Open
SAY-5 wants to merge 3 commits into
Open
fix(zod-openapi): inherit defaultHook from parent app on nested routes#1878SAY-5 wants to merge 3 commits into
SAY-5 wants to merge 3 commits into
Conversation
Closes honojs#1306 Signed-off-by: SAY-5 <say.apm35@gmail.com>
🦋 Changeset detectedLatest commit: fe3858b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1878 +/- ##
==========================================
+ Coverage 92.00% 92.01% +0.01%
==========================================
Files 115 115
Lines 3925 3930 +5
Branches 1005 1009 +4
==========================================
+ Hits 3611 3616 +5
Misses 282 282
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: SAY-5 <say.apm35@gmail.com>
Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The author should do the following, if applicable
yarn changesetat the top of this repo and push the changesetCloses #1306.
When mounting a nested
OpenAPIHonoviaapp.route(path, subApp), the sub-app's routes did not pick up the parent'sdefaultHook. The default hook on the parent was only applied to routes registered directly on the parent (PR #408did the analogous fix forbasePath()).The validator's
hookparameter defaulted tothis.defaultHookat registration time, so sub-app routes registered before mounting were bound toundefined. Switched the default to a lazy wrapper that readsthis.defaultHookat request time, and propagated the parent'sdefaultHookto the sub-app onroute()when the sub-app does not declare its own.Added a regression test under the
Routersdescribe block that fails onmainand passes with the fix.