Skip to content

Add GOP upload type and Documents section to admission profile#21462

Merged
buddhika75 merged 1 commit into
developmentfrom
21170-receive-gop-from-credit-company
Jun 13, 2026
Merged

Add GOP upload type and Documents section to admission profile#21462
buddhika75 merged 1 commit into
developmentfrom
21170-receive-gop-from-credit-company

Conversation

@buddhika75

@buddhika75 buddhika75 commented Jun 13, 2026

Copy link
Copy Markdown
Member

Changes

1. New GOP upload type

  • Added Inward_GOP("GOP") enum value to UploadType
  • Included in the inward document upload type dropdown

2. Documents section on admission profile

  • Created new Documents panel on the admission profile page (Column 4, between Pharmaceuticals and Reports)
  • Moved Fill Forms and Documents buttons from Clinical Data panel into this new section
  • Clinical Data panel now has cleaner layout with remaining buttons

How to test

  1. Open an admission profile
  2. Click the Documents button in the new Documents section
  3. Select GOP from the Document Type dropdown
  4. Choose a file and click Upload

Closes #21170

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Added support for uploading GOP documents alongside existing inward document types.
    • Updated the admission profile screen with new navigation options, including Diagnosis Card and Clinical Discharge.
    • Added quick access to Fill Forms and Documents from the Documents area.
  • UI Changes

    • Reorganized action buttons on the admission profile page for easier access to clinical and document-related tasks.

- Add Inward_GOP enum value to UploadType
- Include GOP in inward document upload type dropdown
- Create new Documents panel on admission profile with Fill Forms and Documents buttons
- Move Forms/Documents buttons out of Clinical Data into new Documents section

Closes #21170
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ecc0570f-268f-428d-b681-0d22e3df3185

📥 Commits

Reviewing files that changed from the base of the PR and between 0075bb2 and 76f17f3.

📒 Files selected for processing (3)
  • src/main/java/com/divudi/bean/inward/InwardDocumentUploadController.java
  • src/main/java/com/divudi/core/data/UploadType.java
  • src/main/webapp/inward/admission_profile.xhtml

Walkthrough

Adds a new Inward_GOP enum constant (label "GOP") to UploadType and registers it in InwardDocumentUploadController.getInwardUploadTypes(). In admission_profile.xhtml, the "Forms" and "Documents" buttons are removed from the Clinical Data section and replaced with "Diagnosis Card" and "Clinical Discharge" buttons; a new Documents panel is added to the right-side column with privilege-gated "Fill Forms" and "Documents" buttons.

Changes

GOP Document Upload and Admission Profile Navigation

Layer / File(s) Summary
Inward_GOP enum constant and upload type registration
src/main/java/com/divudi/core/data/UploadType.java, src/main/java/com/divudi/bean/inward/InwardDocumentUploadController.java
Inward_GOP("GOP") constant is added to the UploadType enum and appended to the list returned by getInwardUploadTypes().
Admission profile button rearrangement and new Documents panel
src/main/webapp/inward/admission_profile.xhtml
"Forms" and "Documents" removed from the Clinical Data button grid, replaced with "Diagnosis Card" and privilege-gated "Clinical Discharge". A new Documents panel is inserted in the right-side column with privilege-gated "Fill Forms" (InwardFormFill) and "Documents" (InwardDocumentUpload) navigation buttons.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • hmislk/hmis#21226: Directly related — it previously updated InwardDocumentUploadController#getInwardUploadTypes() and the UploadType enum to add another inward document type, the same pattern used here for Inward_GOP.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding GOP upload support and a Documents section on the admission profile.
Linked Issues check ✅ Passed The changes add GOP as an upload type and expose it in the existing upload flow, satisfying the linked issue request.
Out of Scope Changes check ✅ Passed The UI rearrangement and new Documents panel are part of the stated objective and do not introduce unrelated changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 21170-receive-gop-from-credit-company

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@buddhika75

Copy link
Copy Markdown
Member Author

Wiki documentation added: Inpatient GOP Document Upload — step-by-step guide for uploading Guarantee of Payment documents from credit companies.

@buddhika75 buddhika75 merged commit 29b06e2 into development Jun 13, 2026
3 checks passed
@buddhika75 buddhika75 deleted the 21170-receive-gop-from-credit-company branch June 13, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Receive GOP from Credit Company. This should be Upload to system.

1 participant