itemsync: Fix GUI freeze when removing all items and on startup#3629
Open
hluk wants to merge 1 commit into
Open
itemsync: Fix GUI freeze when removing all items and on startup#3629hluk wants to merge 1 commit into
hluk wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3629 +/- ##
==========================================
- Coverage 74.43% 74.32% -0.12%
==========================================
Files 253 253
Lines 37916 37947 +31
Branches 5120 5124 +4
==========================================
- Hits 28222 28203 -19
- Misses 9694 9744 +50 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Batch the duplicate-baseName check when removing items so the model is scanned once instead of once per removed row, reducing O(N²) to O(N+M). Skip file-open retries (with sleep) for read-only operations; transient failures are handled by the file watcher on the next cycle. This prevents accumulated sleep time from freezing the UI on startup after a crash. Log a warning when a sync file exists but cannot be opened for reading; use debug level when the file was simply deleted (normal sync operation). Assisted-by: Claude (Anthropic)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch the duplicate-baseName check when removing items so the model is scanned once instead of once per removed row, reducing O(N²) to O(N+M).
Skip file-open retries (with sleep) for read-only operations; transient failures are handled by the file watcher on the next cycle. This prevents accumulated sleep time from freezing the UI on startup after a crash.
Always log a warning when a sync file cannot be opened for reading.
Assisted-by: Claude (Anthropic)