Windows: Fix blank window in RDP sessions#3624
Open
hluk wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3624 +/- ##
==========================================
- Coverage 74.43% 74.33% -0.11%
==========================================
Files 253 253
Lines 37916 37916
Branches 5120 5115 -5
==========================================
- Hits 28222 28184 -38
- Misses 9694 9732 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a Windows-specific usability issue in Remote Desktop (RDP) sessions where CopyQ can become effectively unusable because the modal “screen capture prevention unavailable” warning dialog is not visible to the user (yet still blocks interaction).
Changes:
- Replaces a
QMessageBox::warning()call with an explicitly constructedQMessageBox. - Attempts to ensure the warning dialog is visible in RDP by explicitly clearing display affinity (
WDA_NONE) on the dialog’s native window handle before executing it.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0580333 to
eef15bb
Compare
Clear the window display affinity before showing the warning dialog so the window is visible during the dialog's nested event loop. Fixes #3621 Assisted-by: Claude (Anthropic)
eef15bb to
6fbc454
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear the window display affinity before showing the warning dialog
so the window is visible during the dialog's nested event loop.
Remove the Settings-based persistence of the warning acknowledgment.
Fixes #3621
Assisted-by: Claude (Anthropic)