Skip to content

Windows: Fix blank window in RDP sessions#3624

Open
hluk wants to merge 1 commit into
masterfrom
fix-blank-window-rdp
Open

Windows: Fix blank window in RDP sessions#3624
hluk wants to merge 1 commit into
masterfrom
fix-blank-window-rdp

Conversation

@hluk
Copy link
Copy Markdown
Owner

@hluk hluk commented Jun 2, 2026

Clear the window display affinity before showing the warning dialog
so the window is visible during the dialog's nested event loop.
Remove the Settings-based persistence of the warning acknowledgment.

Fixes #3621

Assisted-by: Claude (Anthropic)

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.33%. Comparing base (ef6e5db) to head (6fbc454).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3624      +/-   ##
==========================================
- Coverage   74.43%   74.33%   -0.11%     
==========================================
  Files         253      253              
  Lines       37916    37916              
  Branches     5120     5115       -5     
==========================================
- Hits        28222    28184      -38     
- Misses       9694     9732      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a Windows-specific usability issue in Remote Desktop (RDP) sessions where CopyQ can become effectively unusable because the modal “screen capture prevention unavailable” warning dialog is not visible to the user (yet still blocks interaction).

Changes:

  • Replaces a QMessageBox::warning() call with an explicitly constructed QMessageBox.
  • Attempts to ensure the warning dialog is visible in RDP by explicitly clearing display affinity (WDA_NONE) on the dialog’s native window handle before executing it.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/platform/win/winplatform.cpp Outdated
@hluk hluk force-pushed the fix-blank-window-rdp branch 4 times, most recently from 0580333 to eef15bb Compare June 3, 2026 15:24
Clear the window display affinity before showing the warning dialog
so the window is visible during the dialog's nested event loop.

Fixes #3621

Assisted-by: Claude (Anthropic)
@hluk hluk force-pushed the fix-blank-window-rdp branch from eef15bb to 6fbc454 Compare June 3, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blank window if RDP is used

2 participants