fix(product-launch): preserve hoisted media offsets#2340
Closed
miguel-heygen wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Consolidated with the related product-launch media, brand, and audio contract fixes in #2408, which preserves this PR’s behavior and regression coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-media-startwhen the product-launch assembler hoists approved frame videos to the host rootReproduction
A frame video with
data-media-start="12.75"lost that attribute during assembly, causing the hoisted host-root video to play from the source beginning. The new test failed before this change and passes afterward.Validation
node --test skills/product-launch-video/scripts/media-contract.test.mjsbun run lint:skillsbun run test:skills(229 passed)git diff --check