fix(skills): honor offline TTS with expired HeyGen auth#2330
Closed
miguel-heygen wants to merge 1 commit into
Closed
fix(skills): honor offline TTS with expired HeyGen auth#2330miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
Collaborator
Author
|
Consolidated with the related TTS provider and error-handling fixes in #2407. The still-relevant behavior from the retired skill path is ported into media-use with regression coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
--providerandHF_TTS_PROVIDER, with the CLI flag taking precedence.Why
A user explicitly selecting local Kokoro still hit
heygenAuthHeaders()during shared audio-engine startup. An expired OAuth credential therefore aborted the run before the engine could honor the offline provider.Reproduction
Confirmed against current
mainwith an expired OAuth credentials file and anaudio_request.jsonselecting Kokoro: the shared engine exited at startup withHeyGen OAuth token expired. The same reproduction exits successfully after this change.Tests
bun run test:skills(234 passed)bun run lint:skillsoxfmt --checkgit diff --check