fix(cli): respect pointer-transparent text in occlusion checks#2326
Open
miguel-heygen wants to merge 1 commit into
Open
fix(cli): respect pointer-transparent text in occlusion checks#2326miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
hyperframes checkno longer reports captions as hidden by a background video when the captions are visibly painted above it withpointer-events: none.Why
The occlusion audit relied on
document.elementFromPoint(), which intentionally skips pointer-transparent content. Caption rails commonly disable pointer events, so the audit saw the video underneath and produced a blockingtext_occludedfalse positive despite correct z-index and verified rendered output.How
During each occlusion probe, pointer-transparent text is made hit-testable just long enough to query the true paint order. Its authored inline value and priority are restored immediately afterward. A regression test covers a video beneath pointer-transparent text and verifies that the original style survives the audit.
Test plan
bun run --cwd packages/cli test -- src/commands/layout-audit.browser.test.ts(39 passed)bun run --cwd packages/cli test(1,650 passed)