fix(snapshot): preserve exact requested times#2325
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Explicit
snapshot --attimestamps now reach the timeline seek unchanged, so before/midpoint/after evidence can target exact fractional-frame transition boundaries.Why
Snapshot rounded every requested time to three decimal places. For values such as
101 / 30, that moves the sample relative to the requested boundary and can capture the wrong side of a deterministic transition.How
Only caller-supplied
--atvalues retain full precision. Automatically generated default and readable-tail samples remain normalized, and existing tail de-duplication behavior is unchanged.Test plan
3.3666666666666667stransition timestampbun run --cwd packages/cli test -- snapshot.test.ts(13/13)bun run --cwd packages/cli typecheckbunx oxlintandbunx oxfmt --checkon changed files