fix(skills): ignore no-SFX storyboard sentinel#2323
Closed
miguel-heygen wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Closing in the owner-scoped backlog value sweep. This is a narrow lint/audit/docs/example/skills refinement, is currently conflicting, or adds more maintenance surface than its demonstrated user impact justifies. Reopen only if a current reproducible case makes it a priority again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Storyboards can now use
sfx: noneto explicitly request silence without triggering an SFX lookup or creating a fakenone.mp3metadata entry.Why
The faceless-explainer workflow treated every non-empty
sfx:value as a catalog query. A literal no-SFX sentinel therefore pollutedaudio_meta.jsonand could overwrite otherwise-valid audio metadata with a nonexistent asset.How
The three shared audio adapters now ignore the case-insensitive
nonesentinel while retaining adjacent real cues. One integration regression test exercises both silent and mixed-cue frames across faceless-explainer, product-launch-video, and pr-to-video.Test plan
node --test skills/faceless-explainer/scripts/audio.test.mjs(4/4)bunx oxlinton the affected adapters and testbunx oxfmt --checkon the affected adapters and testbun run --cwd packages/cli gen:skills-manifest --checkgit diff --check