fix(transcribe): avoid Python whisper CLI#2284
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Only discover
whisper-cliwhen looking for a system whisper.cpp binary.Why
The Python OpenAI Whisper package also installs a
whisperexecutable. HyperFrames treated that unrelated CLI as whisper.cpp and passed incompatible flags, causing transcription to fail before fallback.How
Remove the ambiguous
whisperexecutable fallback and add a regression test that places a fake Python-stylewhisperon PATH.Test plan
bun run --filter @hyperframes/cli test(128 files, 1637 tests)bun run --filter @hyperframes/cli typecheckbunx oxfmt --check packages/cli/src/whisper/manager.ts packages/cli/src/whisper/manager.test.tsbunx oxlint packages/cli/src/whisper/manager.ts packages/cli/src/whisper/manager.test.tsgit diff --check