Add simplemap backend#36
Conversation
yaziine
left a comment
yaziine
left a comment
There was a problem hiding this comment.
Hey @mpodlodowski, thank you for submitting this PR. I have left a comment feel free to tell me what do you think.
Let's refer this to #12.
| } | ||
|
|
||
| return nil, backend.ErrNotFound | ||
| } |
There was a problem hiding this comment.
I think that this is redundant with what we do in the convert function. Moreover you are not handling all the primitive and this is very problematic, for example if the type is an int64 the method will end with a backend.ErrNotFound error.
What can you do to improve this ?
There is also the Unmarshaler and StructLoader interface which can be used maybe you can take a look at them (it's just a proposal not sure that is the correct way to go).
There was a problem hiding this comment.
Thank you! Tried the StructLoader way, take a look :)
rogpeppe
left a comment
rogpeppe
left a comment
There was a problem hiding this comment.
LGTM modulo a few issues, thanks! I suspect that map[string]string is the way to go here.
| continue | ||
| } | ||
| mapRef := reflect.ValueOf(mapVal) | ||
| f.Value.Set(mapRef) |
There was a problem hiding this comment.
This will panic if the mapVal does not have the same type as f.Value. We could return an error if the types aren't identical, but this might be perceived as being overly restrictive, because (for example) you wouldn't be able to use an int-valued map item to fill a float-valued struct field.
Perhaps it would be easiest to implement the Backend on map[string]string instead of map[string]interface{} and then just implement the Get method?
| ) | ||
|
|
||
| // Backend that loads config from map | ||
| type Backend struct { |
There was a problem hiding this comment.
How about just:
type Backend map[string]interface{}
?
Then we wouldn't need the NewBackend constructor function.
| Timeout time.Duration `config:"Timeout"` | ||
| } | ||
|
|
||
| b := simplemap.NewBackend(map[string]interface{}{ |
There was a problem hiding this comment.
Let's have some test cases that test error cases, such as mismatched types, please.
|
@mpodlodowski thanks for your code! Are you planning to make it to the end? |
4 participants
No description provided.