H-6460: Finish ds-components beta recipe cleanup#8673
H-6460: Finish ds-components beta recipe cleanup#8673
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR SummaryLow Risk Overview Replaces refractive/glass effects in Reviewed by Cursor Bugbot for commit 0d5eb4a. Bugbot is set up for automated code reviews on this repo. Configure here. |
| borderRadius: `[${THUMB_RADIUS}px]`, | ||
| border: "[1px solid rgba(255,255,255,0.55)]", | ||
| background: | ||
| "[linear-gradient(180deg, rgba(255,255,255,0.98) 0%, rgba(245,247,250,0.92) 100%)]", |
There was a problem hiding this comment.
Unused refractive props remain in SwitchProps interface
Medium Severity
The SwitchProps interface still declares specularOpacity, specularSaturation, and blurLevel props, but these were only used to configure the now-removed refractive.div component. The Switch component function at line 80 doesn't even destructure them, so passing these props has no effect. This is misleading to consumers who may believe they can control visual effects that no longer exist.
Reviewed by Cursor Bugbot for commit 4982a3f. Configure here.
bcf3239 to
980f377
Compare
4982a3f to
ea67c84
Compare
| borderRadius: `[${THUMB_RADIUS}px]`, | ||
| border: "[1px solid rgba(255,255,255,0.55)]", | ||
| background: | ||
| "[linear-gradient(180deg, rgba(255,255,255,0.98) 0%, rgba(245,247,250,0.92) 100%)]", |
There was a problem hiding this comment.
Unused refractive props remain in SwitchProps interface
Low Severity
The SwitchProps interface still declares specularOpacity, specularSaturation, and blurLevel properties, but these were only used by the now-removed refractive.div component. They are not destructured in the component function (line 80–85) and have no effect on rendering. Consumers of Switch may incorrectly believe these props control visual behavior. Since the entire purpose of this PR is to remove refractive, these leftover props are dead code that belongs to the removed feature.
Reviewed by Cursor Bugbot for commit ea67c84. Configure here.
🤖 Augment PR SummarySummary: This PR removes the Changes:
Technical Notes: This keeps the Ark UI structure intact while eliminating the refractive SVG-filter based effect and its dependency edge. 🤖 Was this summary useful? React with 👍 or 👎 |
| height: `[${THUMB_HEIGHT}px]`, | ||
| borderRadius: `[${THUMB_RADIUS}px]`, | ||
| border: "[1px solid rgba(255,255,255,0.45)]", | ||
| background: |
There was a problem hiding this comment.
thumbInnerStyles now sets an opaque background gradient, so the existing backgroundColor changes in &[data-dragging] > div (and similarly in Switch’s &[data-active] > div) likely won’t be visible; consider aligning state styling to the same CSS property to ensure the intended feedback shows up.
Severity: low
Other Locations
libs/@hashintel/ds-components/src/components/Switch/switch.tsx:59
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
980f377 to
86889ff
Compare
ea67c84 to
0d5eb4a
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0d5eb4a. Configure here.
| borderRadius: `[${THUMB_RADIUS}px]`, | ||
| border: "[1px solid rgba(255,255,255,0.55)]", | ||
| background: | ||
| "[linear-gradient(180deg, rgba(255,255,255,0.98) 0%, rgba(245,247,250,0.92) 100%)]", |
There was a problem hiding this comment.
Unused refractive props remain in SwitchProps interface
Low Severity
The SwitchProps interface still declares specularOpacity, specularSaturation, and blurLevel as optional props, but these were only used to configure the now-removed refractive.div component. They are never destructured or referenced in the Switch component body, making them dead code in the public API. Consumers passing these props would see no effect.
Reviewed by Cursor Bugbot for commit 0d5eb4a. Configure here.
Amp-Thread-ID: https://ampcode.com/threads/T-019dd8a0-e53b-724d-bd27-44a37fb498db Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019dd8a0-e53b-724d-bd27-44a37fb498db Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e01c3-d80d-75ae-adc9-072975f4f3ed Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e01c3-d80d-75ae-adc9-072975f4f3ed Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e01c3-d80d-75ae-adc9-072975f4f3ed Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e01c3-d80d-75ae-adc9-072975f4f3ed Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e01d6-155c-75ba-95ec-f6520abe62fe Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e01d6-155c-75ba-95ec-f6520abe62fe Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e01d6-155c-75ba-95ec-f6520abe62fe Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e01d6-155c-75ba-95ec-f6520abe62fe Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e01d6-155c-75ba-95ec-f6520abe62fe Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e01d6-155c-75ba-95ec-f6520abe62fe Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e01f6-7782-74d7-9692-69f8c40b243d Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e01f6-7782-74d7-9692-69f8c40b243d Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e01f6-7782-74d7-9692-69f8c40b243d Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e0264-82c6-775a-b63f-3b6ff8006e1d Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e0264-82c6-775a-b63f-3b6ff8006e1d Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e0264-82c6-775a-b63f-3b6ff8006e1d Co-authored-by: Amp <amp@ampcode.com>
bdc0a1a to
0722077
Compare
|
This pull request is abnormally large and would use a significant amount of tokens to review. If you still wish to review it, comment "augment review" and we will review it. |



🌟 What is the purpose of this PR?
Finish the remaining
@hashintel/ds-componentsbeta-structure cleanup for H-6460 by flattening the lingeringsrc/betacomponent layout, converting the last Panda config recipes to runtime recipes, and removing transitional preset and Figma tooling leftovers that are no longer part of the package workflow.🔗 Related links
🚫 Blocked by
🔍 What does this change?
src/betacomponent roots into the sibling-file pattern (foo.tsx,foo.recipe.ts,foo.stories.ts) and updates affected story imports across the beta surface.scripts/migrate-beta-fractal-pilots.tsandscripts/migrate-beta-fractal-pilots.test.tsto support the later migration batches and preserve the explicit.recipe/.storiesimport behavior.defineSlotRecipe(...)holdouts to runtimesva(...)recipes, deletessrc/preset/recipes.ts, and removes the temporary recipe registration wiring fromsrc/preset.ts.colorPaletteinstead of the broader registry-era suppression.@hashintel/refractiveusage fromds-componentsfor now as part of the beta-surface simplification.HANDOFF.md,figma.config.json, and the unused@figma/code-connectdependency.Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
TODO(beta-graduation)export-line suppressions for strict-token issues; those were intentionally left for a later cleanup pass.🐾 Next steps
src/betaintosrc/components.🛡 What tests cover this?
yarn fix:eslintyarn fix:formatyarn lint:tscyarn test:unityarn build❓ How to test this?
ln/ds-random-fixing.yarn fix:eslint,yarn fix:format,yarn lint:tsc,yarn test:unit, andyarn buildfromlibs/@hashintel/ds-components.src/preset/recipes.ts/figma.config.jsonare gone.📹 Demo