Skip to content

BE-482: HashQL: Remove logical not from MIR and fix postgres boolean lowering #8595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
indietyp wants to merge 8 commits into
base: bm/be-474-hashql-take-into-account-terminators-eligibility-when
Choose a base branch
from

chore: fix doctests

f1bc346
Select commit
Loading
Failed to load commit list.
Open

BE-482: HashQL: Remove logical not from MIR and fix postgres boolean lowering #8595

chore: fix doctests
f1bc346
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 12, 2026 in 0s

63.61% (+0.33%) compared to 400a216

View this Pull Request on Codecov

63.61% (+0.33%) compared to 400a216

Details

Codecov Report

❌ Patch coverage is 78.97727% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.61%. Comparing base (400a216) to head (f1bc346).

Files with missing lines Patch % Lines
libs/@local/hashql/eval/src/postgres/filter/mod.rs 83.56% 12 Missing ⚠️
libs/@local/hashql/mir/src/body/rvalue/unary.rs 33.33% 10 Missing ⚠️
libs/@local/hashql/eval/src/postgres/types.rs 55.00% 9 Missing ⚠️
...hashql/mir/src/pass/transform/inst_simplify/mod.rs 20.00% 4 Missing ⚠️
libs/@local/hashql/eval/src/postgres/error.rs 0.00% 1 Missing ⚠️
libs/@local/hashql/mir/src/reify/rvalue.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                                         Coverage Diff                                         @@
##           bm/be-474-hashql-take-into-account-terminators-eligibility-when    #8595      +/-   ##
===================================================================================================
+ Coverage                                                            63.27%   63.61%   +0.33%     
===================================================================================================
  Files                                                                 1383     1274     -109     
  Lines                                                               144070   137848    -6222     
  Branches                                                              5893     5519     -374     
===================================================================================================
- Hits                                                                 91164    87688    -3476     
+ Misses                                                               51946    49249    -2697     
+ Partials                                                               960      911      -49

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov