Skip to content
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"utils-merge": "1.0.1"
},
"devDependencies": {
"eslint": "7.32.0",
"eslint": "10.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade to eslint@10.0.0 will break your project's build and development workflow due to several critical issues.

  • Node.js Incompatibility: Your package.json specifies a Node.js engine compatibility of >= 0.10.0. However, recent ESLint versions require much newer Node.js versions:

    • ESLint v8 requires Node.js ^12.22.0 || ^14.17.0 || >=16.0.0.
    • ESLint v9 requires Node.js ^18.18.0 || ^20.9.0 || >=22.0.0.
      This version mismatch will cause the npm run lint command to fail.
  • Major Breaking Changes: This is a jump from v7 to v10, which includes multiple major versions (v8, v9). Each introduced significant breaking changes, such as new rules, deprecated rules, and a new configuration file format (eslint.config.js) in v9. Migrating will require a substantial effort to update your ESLint configuration.

  • Version Stability: eslint@10.0.0 does not appear to be a stable, public release at this time. It is highly recommended to use stable dependency versions.

To resolve the security vulnerability without breaking your project, please consider:

  1. Upgrading your project's required Node.js version in engines and undertaking the necessary ESLint configuration migration.
  2. Exploring alternative ways to patch the underlying ajv vulnerability, for example by using overrides in package.json (if your npm version supports it) to force a patched version of ajv while remaining on ESLint v7.

"mocha": "9.2.2",
"nyc": "15.1.0",
"supertest": "6.3.4"
Expand Down