forked from senchalabs/connect
-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Fix for 2 vulnerabilities #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hashim21223445
wants to merge
2
commits into
master
Choose a base branch
from
snyk-fix-8f9616f8296c7d451b37e542fa433d06
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These dependency upgrades introduce significant breaking changes that are likely to break the build.
ESLint
7.32.0->9.26.0: This is a major jump across two major versions..eslintrc.*configuration files in favor of the new flat config system (eslint.config.js). The project will need a new ESLint configuration file.^18.18.0,^20.9.0, or>=21.1.0. This conflicts with theengines.nodefield inpackage.jsonwhich specifies">= 0.10.0".Mocha
9.2.2->10.6.0: Mocha v10 dropped support for Node.js versions below 14. This also conflicts with the project's stated Node.js support.While these upgrades fix security vulnerabilities, they require careful migration. It's recommended to address these breaking changes before merging. This might involve:
engines.nodefield inpackage.jsonto a version range compatible with both new dependencies (e.g.,^18.18.0 || ^20.9.0).eslint.config.js.npm installand thennpm run lintandnpm testto identify and fix any resulting issues.