Skip to content
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
"utils-merge": "1.0.1"
},
"devDependencies": {
"eslint": "7.32.0",
"mocha": "9.2.2",
"eslint": "9.26.0",
"mocha": "10.6.0",
Comment on lines +26 to +27

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency upgrades introduce significant breaking changes that are likely to break the build.

  • ESLint 7.32.0 -> 9.26.0: This is a major jump across two major versions.

    • Breaking Config Change: ESLint v9.0.0 removed support for the old .eslintrc.* configuration files in favor of the new flat config system (eslint.config.js). The project will need a new ESLint configuration file.
    • Node.js Version: ESLint v9 requires Node.js ^18.18.0, ^20.9.0, or >=21.1.0. This conflicts with the engines.node field in package.json which specifies ">= 0.10.0".
  • Mocha 9.2.2 -> 10.6.0: Mocha v10 dropped support for Node.js versions below 14. This also conflicts with the project's stated Node.js support.

While these upgrades fix security vulnerabilities, they require careful migration. It's recommended to address these breaking changes before merging. This might involve:

  1. Updating the engines.node field in package.json to a version range compatible with both new dependencies (e.g., ^18.18.0 || ^20.9.0).
  2. Creating a new eslint.config.js.
  3. Running npm install and then npm run lint and npm test to identify and fix any resulting issues.

"nyc": "15.1.0",
"supertest": "6.3.4"
},
Expand Down