This repository was archived by the owner on Mar 26, 2026. It is now read-only.
vm-import-controller Change StorageClassName to StorageClass#1008
Open
abonillabeeche wants to merge 1 commit into
Open
vm-import-controller Change StorageClassName to StorageClass#1008abonillabeeche wants to merge 1 commit into
abonillabeeche wants to merge 1 commit into
Conversation
Change StorageClassName to StorageClass to match the chart
torchiaf
suggested changes
Jun 6, 2024
Collaborator
There was a problem hiding this comment.
Thanks @abonillabeeche . Is the bug affecting only the 1.2 version? in this case, could you please change the target branch? It should be release-harvester-v1.2.
Otherwise we should push on master and create the backports afterward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change StorageClassName to StorageClass to match the chart
Summary
The UI asks for a StorageClass but we pass a StorageClassName, which has no match. Therefore the chart uses the default StorageClass.
PR Checklist
Fixes #
While creating a custom migration scenario, we observed the preferred StorageClass wasn't in use. After looking into it, Gaurav pointed out the incorrect syntax was used.
Areas or cases that should be tested
Upgrade from 1.2.1, then edit and Save the AddOn.
Areas which could experience regressions
This change, when Saved, will create another PVC and delete the old one in the correct StorageClass as orignally defined vs the default SC. It could cause disk utilization issues if the user expected them somewhere else (which was originally wrong)