Repository navigation
feat(chat): add full-screen image attachment actions - #4
Conversation
Signed-off-by: Greg Lindberg <greglindberg@gmail.com>
|
Thank you for the thoughtful implementation and for keeping the Relay/media security boundary intact. I tested this branch in a temporary merge with the current main branch: typecheck, 76 unit tests, static checks, production build, and all 34 end-to-end tests passed. We are keeping this PR unmerged for now because two user-facing cases still need work:
Please add focus containment (or make the background inert), restore focus to the trigger, cover Tab/Escape behavior in Playwright, and either provide a safe fallback for non-CORS images or explicitly limit the action to downloadable Relay media. The branch is also behind main, so please update it before the next CI run. The overall direction is good, and I will be glad to re-review once these cases are addressed. Thank you again. |
Closes #3
What changed
Why
The web client only rendered a small inline preview, so agent-generated PNGs could not be inspected or handled with the native client image actions.
Security and protocol notes
This change reuses the existing authenticated media fetch and message-deletion paths. It does not alter Relay events, signing, identity storage, or upload behavior. Protected object URLs remain ephemeral and are not exposed as copied/shared links.
Screenshots
Captured from compiled demo mode with synthetic identities and
relay.example.com; no private Relay or account data is present.Desktop (1280x720)
Mobile (390x844)
Validation
npm run typechecknpm test(76 tests)npm run checknpm run build:e2enpx playwright test tests/e2e/smoke.spec.ts --grep "message images expand"webandagent-control)