Repository navigation
ci: adopt the Happenv package standard - #1
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Restrict GitHub Actions Dependabot updates and correct .npmrc’s release-age value.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Aligns the package with the Happenv skeleton through expanded CI, tooling, documentation, security automation, and testing while preserving runtime behavior and public APIs.
Changes:
- Adds PHP/Laravel/Filament test matrices and browser testing.
- Adds static analysis, formatting, release, dependency, and security workflows.
- Updates package metadata, documentation, and development tooling.
- Follow-ups remain for Dependabot action update restrictions and npm release-age configuration.
| File | Summary |
|---|---|
UPGRADING.md |
Adds upgrade guidance. |
tests/Unit/TranslationsTest.php |
Updates translation test syntax. |
tests/TestCase.php |
Adds deprecation detection. |
tests/Pest.php |
Enables strict typing. |
tests/PanelTestCase.php |
Updates provider setup. |
tests/Fixtures/User.php |
Applies strict typing. |
tests/Fixtures/CustomLogin.php |
Applies strict typing. |
tests/Feature/LoginMultiFactorTest.php |
Simplifies test state handling. |
tests/Browser/TurnstileWidgetTest.php |
Updates browser assertions. |
src/TurnstilePlugin.php |
Cleans up imports. |
src/Rules/TurnstileRule.php |
Reviewed for internal compatibility changes. |
src/Pages/Auth/Register.php |
Applies strict typing. |
src/Pages/Auth/PasswordReset/RequestPasswordReset.php |
Applies strict typing. |
src/Pages/Auth/Login.php |
Applies strict typing. |
src/Http/TurnstileVerifier.php |
Applies strict typing. |
src/Forms/Components/Turnstile.php |
Reviewed for equivalent internal refactoring. |
src/FilamentTurnstileServiceProvider.php |
Applies strict typing. |
src/Concerns/InteractsWithTurnstile.php |
Reviewed for formatting and compatibility. |
rector.php |
Configures Rector and exclusions. |
README.md |
Restructures documentation. |
pint.json |
Adds formatting configuration. |
phpunit.xml.dist |
Enables strict PHPUnit settings. |
phpstan.neon.dist |
Adds PHPStan configuration. |
phpstan-baseline.neon |
Records known analysis exceptions. |
package.json |
Configures Playwright tooling. |
package-lock.json |
Locks npm dependencies. |
LICENSE.md |
Adds the license text. |
composer.json |
Updates metadata, scripts, and development tooling. |
CHANGELOG.md |
Restores release history. |
.nvmrc |
Pins Node.js. |
.npmrc |
Configures npm policies. |
.gitignore |
Updates ignored files. |
.github/zizmor.yml |
Configures workflow security scanning. |
.github/workflows/zizmor.yml |
Adds workflow security checks. |
.github/workflows/update-changelog.yml |
Adds changelog automation. |
.github/workflows/trufflehog.yml |
Adds secret scanning. |
.github/workflows/tests.yml |
Adds the test matrix. |
.github/workflows/quality.yml |
Adds quality checks. |
.github/workflows/pr-title.yml |
Adds pull request title validation. |
.github/workflows/phpstan.yml |
Adds static analysis workflow. |
.github/workflows/dependabot-auto-merge.yml |
Adds dependency auto-merge automation. |
.github/workflows/composer-audit.yml |
Adds Composer security auditing. |
.github/workflows/browser-tests.yml |
Adds browser testing. |
.github/SECURITY.md |
Adds security guidance. |
.github/release.yml |
Adds release configuration. |
.github/ISSUE_TEMPLATE/config.yml |
Configures issue templates. |
.github/ISSUE_TEMPLATE/bug.yml |
Adds a bug report form. |
.github/dependabot.yml |
Configures dependency updates. |
.github/CONTRIBUTING.md |
Adds contribution guidance. |
.gitattributes |
Adds repository and archive rules. |
.editorconfig |
Defines formatting conventions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -0,0 +1 @@ | |||
| min-release-age=7 | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Brings the package in line with the Happenv package skeleton (
happenv-com/plugin-skeleton, public Filament plugin, browser tests, no npm-built assets). No change to runtime behaviour or public API.What changed
tests.yml,browser-tests.yml,phpstan.yml,quality.yml,composer-audit.yml,trufflehog.yml,zizmor.yml,pr-title.yml,update-changelog.yml,dependabot-auto-merge.yml, plusdependabot.yml(Actions, Composer, npm),release.yml,zizmor.yml,SECURITY.md,CONTRIBUTING.md, issue forms.challenges.cloudflare.com, so they need network access.composer.jsonallows them (explained in a comment intests.yml):pint.json,rector.php,phpstan.neon.dist(Larastan level 6 with deprecation rules,configDirectories: [config]soenv()in the config file is allowed),.editorconfig,.gitattributes,.npmrc,.nvmrc.phpunit.xml.distnow uses the skeleton's strict settings (failOnDeprecation,ignoreIndirectDeprecations, random order, …) and keeps the package's env.support,branch-aliasdev-1.x, and the skeleton's scripts.testnow runs Unit and Feature, andtest:browseris renamed totest-browser.require-devwidened so the matrix can resolve: Pest^4.0 || ^5.0, testbench^10.0 || ^11.0. Added Larastan, Rector, Pint, composer-normalize and collision.requireis unchanged.package-lock.jsonis committed now (it was gitignored), becausebrowser-tests.ymlrunsnpm ci.connect_timeout/timeoutconfig keys and an optional@sourceline for custom themes.breaking-change,dependencies,skip-changelogcreated.Reviewer notes
src/changed, formatting and internal only:declare(strict_types=1)in the service provider,TurnstileVerifierand the three auth page classes.Turnstile::shouldRenderWidget().ResetPasswordimported inTurnstilePlugin.resources/viewsandresources/langare unchanged.rector.php):ArrayToFirstClassCallableRector: Rector crashes onis_callable([parent::class, …])in the trait, and a path-scoped skip does not help.RemoveExtraParametersRectorforsrc/Testing/TestsTurnstile.php: it would strip the$schemaargument from the Livewire test macros, which is a real behaviour change.LaravelLevelSetList::UP_TO_LARAVEL_110instead ofwithComposerBased(laravel: true), becausecomposer.jsonstill allows Laravel 11. Following the installed Laravel would rewrite code into Laravel 13-only forms.is_callable(parent::…)in the trait.??on verifier results.TestsTurnstile.@mixin Testable.Analysis is clean on both Filament 4 and 5 with the baseline.
TestCase::setUp().assertSee()instead of the deprecatedwaitForText(). It is whatwaitForText()called, and the deprecation output failed the strict run.