Repository navigation
feat: Add external links to tabs #2243 - #2501
Conversation
|
Fixes #2243 SummaryAdds an optional When Tests
|
mturoci
left a comment
There was a problem hiding this comment.
Code LGTM.
Found 1 minor styling bug for visited link state. Would be better if the visited link style would be the same as non visited (respecting theme color).
Screen.Recording.2026-09-01.at.4.44.25.PM.mov
|
Added a small fix to above styling mismatch. Let me know if this works. I have added a prevent default for the |
|
Isn't there a way to just override :visited style for the link? Would be more explicit about the actual intent. The JS solution may also potentially turn off other browser behavior we would desire. Better to just fix styling and not touch anything else. |
|
Hi @mturoci,
I found it is possible to do this with custom html attribute ( is this a good approach to use here? |
|
Hey @himaSH97. See b958521 for the proper solution. I assume your attempts just needed an I tested around and couldn't find any more issues. Please do the same and let me know in case you still find some bug. If not, I we are good to merge this. |

The PR fulfills these requirements: (check all the apply)
mainbranch.feat: Add a button #xxx, where "xxx" is the issue number).Closes #xxx, where "xxx" is the issue number.uifolder, unit tests (make test) still pass.