Skip to content

Make progress_bar inherit background #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gyscos merged 1 commit into from
Jul 14, 2026
Merged

Make progress_bar inherit background #877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions cursive-core/src/views/progress_bar.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use crate::align::HAlign;
use crate::style::{ColorStyle, ColorType, Effect, PaletteColor};
use crate::style::{ColorStyle, ColorType, PaletteColor};
use crate::utils::Counter;
use crate::view::View;
use crate::{Printer, With};
Expand Down Expand Up @@ -295,14 +295,14 @@ impl View for ProgressBar {
let offset = HAlign::Center.get_offset(label.len(), printer.size.x);

let color_style = ColorStyle::new(PaletteColor::HighlightText, self.color);
let reverse_style = ColorStyle::new(self.color, ColorType::InheritParent);

printer.with_color(reverse_style, |printer| {
printer.print((length, 0), sub_block(extra));
printer.print((offset, 0), &label);
});

printer.with_color(color_style, |printer| {
// TODO: Instead, write it with self.color and inherit_parent background?
// Draw the right half of the label in reverse
printer.with_effect(Effect::Reverse, |printer| {
printer.print((length, 0), sub_block(extra));
printer.print((offset, 0), &label);
});
let printer = &printer.cropped((length, 1));
printer.print_hline((0, 0), length, " ");

Expand Down