Ensures CollectionNavigator does not repond to alt or ctrl keys#5014
Open
Ensures CollectionNavigator does not repond to alt or ctrl keys#5014
CollectionNavigator does not repond to alt or ctrl keys#5014Conversation
IsCompatibleKey now rejects keys with Alt or Ctrl modifiers, ensuring only plain character keys are accepted for search. Added tests to verify this behavior, including scenarios with AssociatedText. Refactored and reformatted tests for clarity, style compliance, and improved thread safety test code.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates collection navigation key filtering so Alt/Ctrl-modified keystrokes don’t trigger collection navigation when kitty “associated text” provides a printable rune.
Changes:
- Tighten
DefaultCollectionNavigatorMatcher.IsCompatibleKeyto reject keys whenIsAltorIsCtrlis set (even ifAsRuneis printable due toAssociatedText). - Add regression coverage for the “AssociatedText present + Alt/Ctrl modifier” scenario in
CollectionNavigatorTests. - Minor test cleanups/formatting adjustments (unused locals, array formatting).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Tests/UnitTestsParallelizable/Text/CollectionNavigatorTests.cs | Adds theory coverage ensuring Alt/Ctrl keys are rejected even when AssociatedText yields a valid rune; includes minor formatting/cleanup. |
| Terminal.Gui/Views/CollectionNavigation/DefaultCollectionNavigatorMatcher.cs | Updates IsCompatibleKey to explicitly reject IsAlt/IsCtrl and reformats IsMatch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Proposed Changes/Todos
Pull request overview
Updates collection navigation key filtering so Alt/Ctrl-modified keystrokes don’t trigger collection navigation when kitty “associated text” provides a printable rune.
Changes:
DefaultCollectionNavigatorMatcher.IsCompatibleKeyto reject keys whenIsAltorIsCtrlis set (even ifAsRuneis printable due toAssociatedText).CollectionNavigatorTests.