-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Allow specifying first and last name during registration/signin #3427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -426,6 +426,16 @@ const authenticationHandler = async ( | |
| } | ||
| } | ||
|
|
||
| // Update the users first and last name if they exist in the authState | ||
| if (authState.data?.firstName || authState.data?.lastName) { | ||
| await updateUser(sub, { | ||
| profile: { | ||
| firstName: authState.data.firstName, | ||
| lastName: authState.data.lastName, | ||
| }, | ||
| }); | ||
| } | ||
|
Comment on lines
+430
to
+437
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We probably need to do some error handling and checking if 1 field is null but the other isnt here, but we can do that in a follow up PR when we actually begin implementing the multiple account flow.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh. Copilot did it for me... Hello? |
||
|
|
||
| // clear any existing oauth application cookies if they exist | ||
| checkAndDeleteOAuthTokenCookies(req, res); | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if they're missing, they'll be
nullI guess?