-
Notifications
You must be signed in to change notification settings - Fork 1
chore: Dependency updates 24/03/2026 #3352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
0ff894d
f435350
f6eef29
7530941
cf680ff
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -90,6 +90,9 @@ const config = tseslint.config( | |
| 'no-console': 'error', | ||
| 'prefer-const': 'error', | ||
|
|
||
| // Requires some significant refactors to PasswordForm and SignedInAs components | ||
| 'react-hooks/set-state-in-effect': 'off', | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This rule got enabled when we upgraded our eslint config versions, it seems like it would take some significant refactors to comply with it though. |
||
|
|
||
| // disabled @guardian/eslint-config rules, we should enable some of them later | ||
| 'import/order': 'off', | ||
| '@typescript-eslint/consistent-type-imports': 'off', | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,6 @@ const config: KnipConfig = { | |
| // but still allows us to see the issues and fix them | ||
| rules: { | ||
| binaries: 'warn', | ||
| classMembers: 'warn', | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Knip no longer supports this option in the latest major version. |
||
| dependencies: 'warn', | ||
| devDependencies: 'warn', | ||
| duplicates: 'warn', | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps remove this as well from the overrides for consistency with the other
package.json?