fix(GuParameterStoreReadPolicy): Remove hard-coded PolicyName#2932
Closed
akash1810 wants to merge 1 commit into
Closed
fix(GuParameterStoreReadPolicy): Remove hard-coded PolicyName#2932akash1810 wants to merge 1 commit into
PolicyName#2932akash1810 wants to merge 1 commit into
Conversation
In v64.0.0 `GuParameterStoreReadPolicy` became a singleton scoped to an `App`. This change stops hard-coding the `PolicyName` property, reverting to AWS default behaviour. This is because `AWS::IAM::Policy` resources in a CFN stack must have a unique policy name.
🦋 Changeset detectedLatest commit: 282d9d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jorgeazevedo
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
In #2929
GuParameterStoreReadPolicybecame a singleton scoped to anApp. This change stops hard-coding thePolicyNameproperty, reverting to AWS default behaviour. This is becauseAWS::IAM::Policyresources in a CFN stack must have a unique policy name. If a CFN stack has two applications (e.g.apiandfrontend) we need twoAWS::IAM::Policy's each with their ownPolicyName.How to test
See updated snapshots.
How can we measure success?
Supporting multiple apps in a single CFN stack. For example https://github.com/guardian/cdk-playground/blob/main/cdk/lib/cdk-playground.ts.
Have we considered potential risks?
This is a functional no-op, however clients would need to update their snapshots.
Checklist
Footnotes
Consider whether this is something that will mean changes to projects that have already been migrated, or to the CDK CLI tool. If changes are required, consider adding a checklist here and/or linking to related PRs. ↩
If you are adding a new construct or pattern, has new documentation been added? If you are amending defaults or changing behaviour, are the existing docs still valid? ↩