fix bad behavior in marshal for empty buffers/strings#16
Merged
paulfitz merged 2 commits intogrist-mainfrom Mar 16, 2026
Merged
fix bad behavior in marshal for empty buffers/strings#16paulfitz merged 2 commits intogrist-mainfrom
paulfitz merged 2 commits intogrist-mainfrom
Conversation
When built with _GLIBCXX_ASSERTIONS (as in Flatpak environments), allMarshal crashes on empty result sets or empty string/blob values due to out-of-bounds vector/string access via operator[]. Fix by using .data() and guarding _writeBytes against zero-length writes. Add tests for empty result sets, empty strings, and empty blobs. Add build:assert script and CI step to catch this class of bug.
paulfitz
added a commit
to gristlabs/grist-core
that referenced
this pull request
Mar 23, 2026
Summary: Upgrades the fork of node-sqlite3 we use to deal with a memory access issue: gristlabs/node-sqlite3#16 Test Plan: existing tests should pass Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D4886
wvengen
added a commit
to wvengen/flathub
that referenced
this pull request
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When built with _GLIBCXX_ASSERTIONS (as in Flatpak environments), allMarshal crashes on empty result sets or empty string/blob values due to out-of-bounds vector/string access via operator[]. Fix by using .data() and guarding _writeBytes against zero-length writes.
Add tests for empty result sets, empty strings, and empty blobs. Add build:assert script and CI step to catch this class of bug.