update actions, and dotnet version

[grimley517]

No description provided.

[Copilot]

Pull request overview

Updates GitHub Actions workflow dependencies (actions used) and bumps the CI .NET SDK version.

Changes:

• Updated workflow actions to newer major versions across Sonar, release, and CI build workflows.
• Updated .github/workflows/dotnet.yml to install .NET SDK 9.0.x instead of 6.0.x.
• Updated artifact upload/download and caching actions to newer major versions.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File	Description
.github/workflows/sonar.yml	Updates Java setup, checkout, and cache action references used by SonarCloud analysis.
.github/workflows/release.yml	Updates checkout/.NET setup/artifact actions used for packaging, validation, testing, and publishing.
.github/workflows/dotnet.yml	Updates checkout/.NET setup/artifact actions and changes the installed .NET SDK version for CI.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Several run: steps in this workflow use PowerShell syntax (e.g., Get-ChildItem, foreach(...)), but the jobs run on ubuntu-latest and these steps don’t set shell: pwsh. Unless the shell is set, these commands will execute under bash and fail. Set defaults.run.shell: pwsh for the workflow/job, or rewrite those commands to bash equivalents.

[grimley517]

@copilot apply changes based on this feedback

[Copilot]

Done in commit 91d7cff. Converted both PowerShell steps to bash equivalents: replaced (Get-ChildItem ...) with $(ls ...) for the validate step, and replaced the foreach(...) loop with a bash for ... do ... done loop (with the path properly quoted) for the publish step.

[Copilot]

The repo’s projects target net6.0 (e.g., src/DecimalChecker/DecimalChecker.csproj). Installing only the .NET 9 SDK here can break dotnet test at runtime if the .NET 6 runtime isn’t available on the runner (newer SDKs don’t necessarily include older runtimes). Prefer installing the SDK/runtime matching the target framework (6.0.x), or install both 6.0.x and 9.0.x if you need 9 for tooling.

Suggested change

	dotnet-version: 9.0.x
	dotnet-version: 6.0.x

[grimley517]

@copilot does setting a global.json solve this? can we remove the project setting to use dotnet 6 and rely on the global.json to set the dotnet version.

[Copilot]

Yes — the combination of global.json (pinning the SDK to 9.0) and updating TargetFramework to net9.0 in the project files resolves the mismatch. Both were done in commit 163307f, so the SDK and runtime are now aligned and no explicit dotnet-version is needed in the workflows.

[grimley517]

nice review @copilot. Can dotnet versions be declared in a single place as opposed in all project definitions?

[Copilot]

nice review @copilot. Can dotnet versions be declared in a single place as opposed in all project definitions?

Yes — done in commit edceeae. Added src/Directory.Build.props that declares <TargetFramework>net9.0</TargetFramework> once, and removed the per-project setting from both .csproj files. MSBuild automatically picks up Directory.Build.props for all projects under that directory.

[grimley517]

@copilot the sonarqube run is failing as it has no config file - can you create a config file for sonarqube please.

[Copilot]

@copilot the sonarqube run is failing as it has no config file - can you create a config file for sonarqube please.

Done in commit 96a06f2. Two changes were made:

1. Added sonar-project.properties at the repo root with the project key, organization, host URL, and coverage report path.
2. Fixed the root cause of the CI failure: the sonar.login parameter is deprecated in SonarScanner v7+ — updated both the begin and end commands in sonar.yml to use sonar.token instead.