Skip to content

IGNITE-11346: Remote client authentication failed for the CommandHand… #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Maxoid wants to merge 3 commits into
base: master
Choose a base branch
from
Open

IGNITE-11346: Remote client authentication failed for the CommandHand… #123

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e011ee2
IGNITE-11346: Remote client authentication failed for the CommandHand…
Maxoid Feb 18, 2019
ea69b17
IGNITE-11346: Remote client authentication failed for the CommandHand…
Maxoid Apr 12, 2019
ed15551
IGNITE-11346: Remote client authentication failed for the CommandHand…
Maxoid Apr 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ...in/java/org/apache/ignite/internal/client/impl/connection/GridClientNioTcpConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,18 @@ else if (now - lastPingSndTime > pingInterval && lastPingRcvTime != Long.MAX_VAL

assert old == null;

GridNioFuture<?> sndFut = ses.send(msg);
GridNioFuture<?> sndFut;
if(sesTok == null && credentials() != null ) {

@ibessonov ibessonov Apr 10, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reformat code according to codestyle.

fut.retryState(TcpClientFuture.STATE_AUTH_RETRY);

GridClientAuthenticationRequest req = buildAuthRequest();

req.requestId(reqId);

sndFut = ses.send(req);

@ibessonov ibessonov Apr 10, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where you send "msg" in this branch. Is it ignored?

@Maxoid Maxoid Apr 12, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message is already pended in the original future (for which status is changing to STATE_AUTH_RETRY). So the message is not ignored but postponed.

} else {

@ibessonov ibessonov Apr 10, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reformat code according to codestyle.

sndFut = ses.send(msg);
}

lastMsgSndTime = System.currentTimeMillis();

Expand Down