fix: resolve Dependabot alerts 441 and 442 - #1405
Draft
dafuga wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
electron-builderto26.15.0, which resolvesapp-builder-libto26.15.0electron-updaterto6.8.9, which removes the remaining olderbuilder-util-runtimeresolutionbuilder-util-runtimeto9.7.0This addresses Dependabot alerts #441 and #442.
Validation
app-builder-lib@26.15.0,builder-util-runtime@9.7.0)package.jsonandyarn.lock)git diff --check: passedyarn test: failed; 29 suites passed, 31 failed, and 1 was skipped. The failing suites report that Electron did not install correctly, and 15 snapshot suites also report failures.yarn lint: failed; the legacy ESLint setup cannot resolveapp/webpack.config.eslint.jsand then exits intemplate-curly-spacingwithCannot read properties of null (reading 'range').yarn build: failed; both npm-backed build commands exit under npm 11 withInvalid property "devEngines.node".Compatibility risk
This moves legacy Electron 12 project tooling across major versions (
electron-builder23 to 26 andelectron-updater4 to 6). The install also reports an unmetelectron-builder-squirrel-windows@26.15.0peer dependency. Packaging and updater behavior therefore need validation in the repository's supported build environment before release.