feat(cross-sell-products): add @daffodil/cross-sell-products - #4551
Open
griest024 wants to merge 4 commits into
Open
feat(cross-sell-products): add @daffodil/cross-sell-products#4551griest024 wants to merge 4 commits into
@daffodil/cross-sell-products#4551griest024 wants to merge 4 commits into
Conversation
griest024
marked this pull request as draft
June 22, 2026 22:19
griest024
marked this pull request as ready for review
June 23, 2026 15:08
Member
|
@griest024 generally idea LGTM, needs a implementation for testing and in-memory before merge. |
Member
Author
|
I also need to remove driver interface and token |
griest024
force-pushed
the
feat/cross-sell/init
branch
from
July 10, 2026 16:10
50d9b20 to
5d0a213
Compare
Member
Author
|
@damienwebdev there really isn't any to implement for the testing driver as the cart testing driver doesn't have an extension point. The in-memory stuff is done though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Current behavior
Fixes: #4519
Part of: #
New behavior
state:
magento driver:
Breaking change?
Additional context