Skip to content

feat(cross-sell-products): add @daffodil/cross-sell-products - #4551

Open
griest024 wants to merge 4 commits into
developfrom
feat/cross-sell/init
Open

feat(cross-sell-products): add @daffodil/cross-sell-products#4551
griest024 wants to merge 4 commits into
developfrom
feat/cross-sell/init

Conversation

@griest024

@griest024 griest024 commented Jun 22, 2026

Copy link
Copy Markdown
Member

PR Checklist

  • Commit message follows our contributing guidelines
  • Tests added/updated (for bug fixes/features)
  • Documentation added/updated (for bug fixes/features)

PR Type

  • Bug fix
  • Feature
  • Style update
  • Refactor
  • Test
  • Build
  • CI
  • Docs
  • Performance
  • Other (please describe)

Current behavior

Fixes: #4519
Part of: #

New behavior

state:

  • meta reducer to add products to entity state
  • meta reducer to remove products from cart
    magento driver:
  • adds fragment to cart query to retrieve cross sells
  • adds transform to cart that transforms the products and adds product IDs

Breaking change?

  • Yes
  • No

Additional context

@griest024
griest024 requested review from a team as code owners June 22, 2026 21:54
@griest024
griest024 marked this pull request as draft June 22, 2026 22:19
@griest024
griest024 marked this pull request as ready for review June 23, 2026 15:08
@damienwebdev

Copy link
Copy Markdown
Member

@griest024 generally idea LGTM, needs a implementation for testing and in-memory before merge.

@griest024

Copy link
Copy Markdown
Member Author

I also need to remove driver interface and token

@griest024
griest024 force-pushed the feat/cross-sell/init branch from 50d9b20 to 5d0a213 Compare July 10, 2026 16:10
@griest024

Copy link
Copy Markdown
Member Author

@damienwebdev there really isn't any to implement for the testing driver as the cart testing driver doesn't have an extension point. The in-memory stuff is done though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create @daffodil/cross-sell package

2 participants