default variable fixes#1376
Open
jbellenger wants to merge 3 commits intographql-rust:masterfrom
Open
Conversation
Null variables in DefaultValuesOfCorrectType validation rule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! I'm the maintainer of graphql-conformance, which verifies spec conformance across the graphql ecosystem. I noticed that juniper has a couple of deviations from the spec and I thought I might be able to contribute a fix for one of the easy ones (see juniper's conformance page for other conformance gaps)
The issue addressed by this PR is that juniper rejects some allowed patterns with variables.
For example, this query is valid and should be executable with empty variables:
Juniper rejects this query in 2 ways:
Queries with this shape are allowed by these sections of the spec:
Finally, the combination of a non-nullable variable with default, plus an unspecified variable, is implemented by this graphql-js test case.
Thank you for considering this PR. I'm not familiar with this code-base or its conventions, so please feel free to point out any issue no matter how small. I went through the checklist in CONTRIBUTING.md, everything passed except for the
make test.bookwhich failed for me in master.