Fix unknown argument validation#1373
Open
zohnannor wants to merge 3 commits intographql-rust:masterfrom
Open
Conversation
LegNeato
requested changes
Apr 29, 2026
Member
LegNeato
left a comment
LegNeato
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks like CI is failing.
Add regression coverage to ensure fields without declared arguments reject unknown arguments.
Author
|
You are right, I updated the old tests and added one for regression coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per GraphQL S5.4.1 Argument Names,
But currently, juniper allows passing the arguments even if the field doesn't have any.
MRE: https://github.com/zohnannor/juniper-mre/tree/unknown-argument-no-error
This can be considered a breaking change, however, anyone relying on this was essentially abusing a bug unknowingly. Any way, should probably be mentioned in the changelog.