Skip to content

fix(check-catalog-info): stage before diffing so drift is actually detected #2298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ricky-undeadcoders wants to merge 1 commit into
base: main
Choose a base branch
from
+351 −4
Open

fix(check-catalog-info): stage before diffing so drift is actually detected #2298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/check-catalog-info.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,13 @@ jobs:
run: |
make catalog-info.yaml

# `git diff --staged` compares the index against HEAD, and nothing here is
# ever staged -- so this check passed unconditionally and let 18 actions go
# unregistered. Stage first so new and modified files both show up.
- name: Check for drift
run: |
git add -A
if ! git diff --staged --exit-code; then
echo "catalog-info.yaml is not up-to-date, please run \`make catalog-info.yaml\` to update this file."
echo "::error::catalog-info.yaml is not up-to-date, please run \`make catalog-info.yaml\` to update this file."
exit 1
fi
Loading
Loading