Fix: Prevent crash in initializeSegmentation when 'mehd' box is missing#532
Closed
AgustinBaffo wants to merge 1 commit into
Closed
Fix: Prevent crash in initializeSegmentation when 'mehd' box is missing#532AgustinBaffo wants to merge 1 commit into
AgustinBaffo wants to merge 1 commit into
Conversation
Member
|
Will be fixed via #530 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I recently upgraded mp4box from v0.5.3 to v2.3.0. I am processing a fragmented MP4 file (generated via Chrome's MediaRecorder) in a streaming format (appending chunks from disk).
When calling
initializeSegmentation()the library crashes with aTypeError.The video file is a valid fragmented MP4 (
isFragmented: true). However, since it is generated by a live recorder it does not contain the optionalmehdbox withinmvex.Here is the minimal code I am using in the client:
Root cause:
I investigated the source code for v2.3.0. The issue seems to be in
ISOFile.writeInitializationSegment(here - introduced in this commit).The code tries to access
fragment_durationfrom themehdbox without verifying if themehdbox actually exists. Whilemoovandmvexare checked (or exist),mehdis optional in the spec and missing in my file.Testing
I have applied this patch locally and it resolves the crash allowing
initializeSegmentation()to proceed correctly with my fragmented files.