fix: expose Err() method to check for configuration errors#90
Open
Yanhu007 wants to merge 1 commit intogorilla:mainfrom
Open
fix: expose Err() method to check for configuration errors#90Yanhu007 wants to merge 1 commit intogorilla:mainfrom
Yanhu007 wants to merge 1 commit intogorilla:mainfrom
Conversation
New() silently stores configuration errors (e.g., missing hash key, invalid block key) in a private field. Users have no way to detect these errors until Encode/Decode fails. Add a public Err() method that returns any stored configuration error, allowing callers to check for misconfiguration immediately after calling New(). Fixes gorilla#89
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89
Problem
New()silently stores configuration errors (missing hash key, invalid block cipher key) in a privateerrfield. There is no way for callers to check ifNew()succeeded — they only discover the problem whenEncode()/Decode()later returns an error.Fix
Add a public
Err()method:This lets callers check for misconfiguration immediately:
This is backward-compatible — no existing API signatures change. All existing tests pass.