CMakeList.txt: fixed inconsistent lib name in .pc#54
Open
MartinPulec wants to merge 1 commit intogopro:masterfrom
Open
CMakeList.txt: fixed inconsistent lib name in .pc#54MartinPulec wants to merge 1 commit intogopro:masterfrom
MartinPulec wants to merge 1 commit intogopro:masterfrom
Conversation
Inconsistent library name `CFHDCodecStatic` was output to pkg-config file (libcineformsdk.pc) while the actual library created on *nix systems is libCFHDCodec.a (similarly for shared build). This is because the target name was put into the .pc file instead of its OUTPUT_NAME property (if defined).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I am proposing following patch to CMakeLists.txt. Basically, in Linux/mac, the generated pkg-config file contains wrong library name because of the following line in CMakeLists.txt:
Because of that, without the patch, the output
libcineformsdk.pcfile contains-lCFHDCodecStaticwhile the actual library built islibCFHDCodec.abecause the substituted name in pc file is the name of the target, not its OUTPUT_NAME property.