Skip to content

WIP: Support Glyphs3-style glyph data incl. writing direction #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anthrotype wants to merge 96 commits into
base: main
Choose a base branch
from
Open

WIP: Support Glyphs3-style glyph data incl. writing direction #818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
96 commits
Select commit Hold shift + click to select a range
5fe3238
WIP update Glyphs Info algorithm
schriftgestalt Apr 20, 2022
9b1a409
add unicodeLegacy
schriftgestalt May 24, 2022
7c9fed3
chane glyph name
schriftgestalt May 24, 2022
433ef5a
WIP: computation of glyphInfo
schriftgestalt May 24, 2022
d3e8f29
Formatting, commented-out unused variables using # Never used
yanone Sep 5, 2022
52900c1
Renaming .production to ._production to avoid overlaps with the .prod…
yanone Sep 5, 2022
10c500b
Making both properties available. glyphsLib contains numerous referen…
yanone Sep 5, 2022
454dc60
Returning unpropagated/empty GlyphsInfo object as a fallback
yanone Sep 5, 2022
232aab1
Formatting, fixed imports
yanone Sep 5, 2022
2442b57
add some tests
schriftgestalt Sep 6, 2022
49258f3
make sure we get the order of arguments right
schriftgestalt Sep 6, 2022
ffd8714
handling of liga suffixes
schriftgestalt Sep 6, 2022
05f0196
debug
schriftgestalt Sep 6, 2022
e82e96f
I get a warning when committing in the Lib folder
schriftgestalt Sep 6, 2022
a4eab6c
adjust the name construction
schriftgestalt Sep 6, 2022
cf93d8f
more liga name fixed
schriftgestalt Sep 7, 2022
e6fdb3c
In line 389, suffix may get reassigned as None, and will then throw a…
yanone Sep 7, 2022
3fbf9b4
Reactivate large chunks of tests, added missing imports
yanone Sep 8, 2022
dad011d
remove debugging
schriftgestalt Sep 8, 2022
2fe423a
New attribute name
yanone Sep 8, 2022
49b4412
Checking for glyph info to not be None in 3 places
yanone Sep 8, 2022
e883c59
Merge branch 'GlyphInfo3' of https://github.com/googlefonts/glyphsLib…
yanone Sep 8, 2022
c1407b2
WIP update Glyphs Info algorithm
schriftgestalt Apr 20, 2022
30111f5
add unicodeLegacy
schriftgestalt May 24, 2022
5922ecb
chane glyph name
schriftgestalt May 24, 2022
132e78d
WIP: computation of glyphInfo
schriftgestalt May 24, 2022
a67347b
Formatting, commented-out unused variables using # Never used
yanone Sep 5, 2022
61d3472
Renaming .production to ._production to avoid overlaps with the .prod…
yanone Sep 5, 2022
9133687
Making both properties available. glyphsLib contains numerous referen…
yanone Sep 5, 2022
a67f3b8
Returning unpropagated/empty GlyphsInfo object as a fallback
yanone Sep 5, 2022
4bfa83a
Formatting, fixed imports
yanone Sep 5, 2022
72b5cd0
add some tests
schriftgestalt Sep 6, 2022
51e128e
make sure we get the order of arguments right
schriftgestalt Sep 6, 2022
dd576fb
handling of liga suffixes
schriftgestalt Sep 6, 2022
b53f53f
debug
schriftgestalt Sep 6, 2022
300909b
I get a warning when committing in the Lib folder
schriftgestalt Sep 6, 2022
e54f228
adjust the name construction
schriftgestalt Sep 6, 2022
70b83c0
more liga name fixed
schriftgestalt Sep 7, 2022
e916dfe
In line 389, suffix may get reassigned as None, and will then throw a…
yanone Sep 7, 2022
a49dd23
Reactivate large chunks of tests, added missing imports
yanone Sep 8, 2022
4e4f8b3
New attribute name
yanone Sep 8, 2022
3918642
Checking for glyph info to not be None in 3 places
yanone Sep 8, 2022
1691e81
Merge branch 'GlyphInfo3' of https://github.com/googlefonts/glyphsLib…
yanone Sep 30, 2022
c7423b9
Update glyphdata_test.py
yanone Oct 7, 2022
3a357ee
WIP update Glyphs Info algorithm
schriftgestalt Apr 20, 2022
92d4f2d
add unicodeLegacy
schriftgestalt May 24, 2022
2439b34
chane glyph name
schriftgestalt May 24, 2022
824824b
WIP: computation of glyphInfo
schriftgestalt May 24, 2022
eff7ba0
Formatting, commented-out unused variables using # Never used
yanone Sep 5, 2022
e302d1b
Renaming .production to ._production to avoid overlaps with the .prod…
yanone Sep 5, 2022
0959b3b
Making both properties available. glyphsLib contains numerous referen…
yanone Sep 5, 2022
cbf4ab6
Returning unpropagated/empty GlyphsInfo object as a fallback
yanone Sep 5, 2022
981bbda
Formatting, fixed imports
yanone Sep 5, 2022
0ff36bd
add some tests
schriftgestalt Sep 6, 2022
184af4e
make sure we get the order of arguments right
schriftgestalt Sep 6, 2022
41a3b16
handling of liga suffixes
schriftgestalt Sep 6, 2022
01ff177
debug
schriftgestalt Sep 6, 2022
5cc0330
I get a warning when committing in the Lib folder
schriftgestalt Sep 6, 2022
da8a517
adjust the name construction
schriftgestalt Sep 6, 2022
8069089
more liga name fixed
schriftgestalt Sep 7, 2022
dbc73a7
In line 389, suffix may get reassigned as None, and will then throw a…
yanone Sep 7, 2022
698b801
Reactivate large chunks of tests, added missing imports
yanone Sep 8, 2022
a3d355f
New attribute name
yanone Sep 8, 2022
294701b
Checking for glyph info to not be None in 3 places
yanone Sep 8, 2022
25a201c
WIP update Glyphs Info algorithm
schriftgestalt Apr 20, 2022
3e02fc4
WIP: computation of glyphInfo
schriftgestalt May 24, 2022
e8af4de
Formatting, commented-out unused variables using # Never used
yanone Sep 5, 2022
d1df41b
Renaming .production to ._production to avoid overlaps with the .prod…
yanone Sep 5, 2022
6bd6c92
Making both properties available. glyphsLib contains numerous referen…
yanone Sep 5, 2022
898592a
Returning unpropagated/empty GlyphsInfo object as a fallback
yanone Sep 5, 2022
642ce31
Formatting, fixed imports
yanone Sep 5, 2022
1be47e8
add some tests
schriftgestalt Sep 6, 2022
cf4cccc
make sure we get the order of arguments right
schriftgestalt Sep 6, 2022
5852ddc
handling of liga suffixes
schriftgestalt Sep 6, 2022
14f000d
debug
schriftgestalt Sep 6, 2022
bfe26ce
adjust the name construction
schriftgestalt Sep 6, 2022
aa89a4e
more liga name fixed
schriftgestalt Sep 7, 2022
caf4bab
In line 389, suffix may get reassigned as None, and will then throw a…
yanone Sep 7, 2022
0de7ab2
Reactivate large chunks of tests, added missing imports
yanone Sep 8, 2022
f63a724
New attribute name
yanone Sep 8, 2022
955f028
Checking for glyph info to not be None in 3 places
yanone Sep 8, 2022
8b4d9f9
remove debugging
schriftgestalt Sep 8, 2022
cb810e6
Update glyphdata_test.py
yanone Oct 7, 2022
874e0d9
extract data loading
schriftgestalt Oct 10, 2022
7ede257
make sure to remove all `None`
schriftgestalt Oct 10, 2022
9f254ab
better comments
schriftgestalt Oct 10, 2022
ed0e414
remove debug
schriftgestalt Oct 10, 2022
dd69122
update test
schriftgestalt Oct 10, 2022
e7cbe78
get most tests to work
schriftgestalt Nov 10, 2022
2637a3c
refactor _construct_liga_info_names_ method to reduce complexity
schriftgestalt Nov 10, 2022
c861b5f
cleanup
schriftgestalt Nov 10, 2022
f1fe508
Merge branch 'GlyphInfo3' of https://github.com/googlefonts/glyphsLib…
yanone Nov 15, 2022
f1b6286
Formatting
yanone Nov 15, 2022
f10e231
Formatting
yanone Nov 15, 2022
2967b03
Formatting
yanone Nov 15, 2022
5426cce
add more tests
schriftgestalt Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ dist/
downloads/
eggs/
.eggs/
lib/
# lib/
lib64/
parts/
sdist/
Expand Down
14,546 changes: 8,164 additions & 6,382 deletions Lib/glyphsLib/data/GlyphData.xml
View file
Open in desktop

Large diffs are not rendered by default.

55,285 changes: 27,643 additions & 27,642 deletions Lib/glyphsLib/data/GlyphData_Ideographs.xml
View file
Open in desktop

Large diffs are not rendered by default.

Loading