Skip to content

impl(o11y): introduce http.response.body_size #4157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diegomarquezp wants to merge 39 commits into
base: main
Choose a base branch
from

fix: use separate logic for unary resposne body size

94e55db
Select commit
Loading
Failed to load commit list.
Open

impl(o11y): introduce http.response.body_size #4157

fix: use separate logic for unary resposne body size
94e55db
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / [gapic-generator-java-root] SonarCloud Code Analysis failed Mar 19, 2026 in 1m 37s

Quality Gate failed

Failed conditions
52.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Annotations

Check failure on line 192 in gax-java/gax-httpjson/src/test/java/com/google/api/gax/httpjson/BodySizeRecordingTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [gapic-generator-java-root] SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=googleapis_gapic-generator-java&issues=AZ0HDaXDcKsPsk4GNO0s&open=AZ0HDaXDcKsPsk4GNO0s&pullRequest=4157

Check warning on line 97 in gax-java/gax-httpjson/src/test/java/com/google/api/gax/httpjson/BodySizeRecordingTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [gapic-generator-java-root] SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=googleapis_gapic-generator-java&issues=AZ0HDaXDcKsPsk4GNO0q&open=AZ0HDaXDcKsPsk4GNO0q&pullRequest=4157

Check warning on line 188 in gax-java/gax/src/main/java/com/google/api/gax/tracing/ApiTracer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [gapic-generator-java-root] SonarCloud Code Analysis

Remove this empty statement. 

See more on https://sonarcloud.io/project/issues?id=googleapis_gapic-generator-java&issues=AZ0HDaTfcKsPsk4GNO0o&open=AZ0HDaTfcKsPsk4GNO0o&pullRequest=4157

Check warning on line 92 in gax-java/gax-httpjson/src/test/java/com/google/api/gax/httpjson/BodySizeRecordingTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [gapic-generator-java-root] SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=googleapis_gapic-generator-java&issues=AZ0HDaXDcKsPsk4GNO0p&open=AZ0HDaXDcKsPsk4GNO0p&pullRequest=4157

Check warning on line 102 in gax-java/gax-httpjson/src/test/java/com/google/api/gax/httpjson/BodySizeRecordingTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [gapic-generator-java-root] SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=googleapis_gapic-generator-java&issues=AZ0HDaXDcKsPsk4GNO0r&open=AZ0HDaXDcKsPsk4GNO0r&pullRequest=4157
View more details on SonarQubeCloud