Skip to content

refactor(core): replace explicit any types with safer modern types #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itwaasyou wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(core): replace explicit any types with safer modern types #2705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ff192a
refactor(core): replace explicit any types with safer modern types
itwaasyou Mar 12, 2026
1089c9a
Merge branch 'main' into fix-generic-yaml-types
itwaasyou Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions src/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,17 @@ export interface GitHubOptions {

type CommitFilter = (commit: Commit) => boolean;

interface GraphQLCommitAuthor {
name?: string;
email?: string;
user?: {
login: string;
} | null;
interface GitHubCreateOptions {
owner: string;
repo: string;
defaultBranch?: string;
apiUrl?: string;
graphqlUrl?: string;
octokitAPIs?: OctokitAPIs;
token?: string;
logger?: Logger;
proxy?: ProxyOption;
fetch?: unknown;
}

interface GraphQLCommit {
Expand Down Expand Up @@ -434,7 +439,7 @@ export class GitHub implements Scm {
}
)) {
// Paginate plugin doesn't have types for listing files on a commit
const data = resp.data as any as {files: {filename: string}[]};
const data = resp.data as unknown as {files: {filename: string}[]};
for (const f of data.files || []) {
if (f.filename) {
files.push(f.filename);
Expand Down
2 changes: 1 addition & 1 deletion src/updaters/generic-yaml.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export class GenericYaml implements Updater {
JSONPath({
resultType: 'all',
path: this.jsonpath,
Comment thread
itwaasyou marked this conversation as resolved.
json: data as any,
json: data as object,
callback: (payload, _payloadType, _fullPayload) => {
if (typeof payload.value !== 'string') {
logger.warn(`No string in ${this.jsonpath}. Skipping.`);
Expand Down
Loading