feat: add ability to output candidate releases#1041
feat: add ability to output candidate releases#1041niieani wants to merge 1 commit intogoogleapis:mainfrom
Conversation
|
Hi @chingor13! I know you must be busy. Any chance you could have a look at this? I'm open to feedback if you want any changes. 🙇 |
|
Hi @niieani , I would be interested to also have a Something like: export async function main() {
...
if (inputs.only === 'list-pull-requests') {
core.debug('Listing pending pull requests');
outputCandidatePRs(await manifest.buildPullRequests());
}
...
}
...
function outputCandidatePRs(prs: ReleasePullRequest[]) {
prs = prs.filter(pr => pr !== undefined);
core.setOutput('prs_pending', prs.length > 0);
if (prs.length) {
core.setOutput('pr', prs[0]);
core.setOutput('prs', JSON.stringify(prs));
}
}So in this case the pr and prs output would be of type ReleasePullRequest object instead of PullRequest object. What do you think about it? |
|
Hi @le-yams ! I think that's a good addition, however note that I've been trying to get this merged since October 2024. |
chingor13
left a comment
There was a problem hiding this comment.
Thanks for this.
I think I'd prefer a dry-run boolean option to mirror what the CLI does rather than maintaining a list of actions.
|
Thank you for taking a look @chingor13. |
|
Sorry to ping you - I was wondering if there's any chance for a merge&release given the code updated based on your review? 🙇 Much appreciated! |
I am also awating this feature for a while specially listing the release candidates, @chingor13 could you please re-review this PR? |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@niieani thanks for this PR. Can you please rebase your branch against the latest |
adds ability to output candidate releases, and candidate PRs without actually releasing or updating PRs
|
@ferrarimarco rebased! |
|
This would be really nice addition to this action and would help optimize the deployments, is there still some change this gets merged some day? |
For the purposes of releasing, it is useful to just get the information of the packages that are about to be released.
If
only: 'list-candidate-releases'is set, only output information about which packages would be released.It provides
releases_pendingandpaths_to_releaseas the outputs.In order to enable this new feature, I've added a new input called
onlythat allows running only the desired functionality ('create-github-releases' | 'list-candidate-releases' | 'update-pull-requests').It is not a breaking change, and is backwards compatible with the
skipGitHubReleaseandskipGitHubPullRequestinputs.