Skip to content

chore: update librarian version and use list syntax for include_list#5443

Merged
sofisl merged 4 commits intomainfrom
update-librarian-config
Apr 17, 2026
Merged

chore: update librarian version and use list syntax for include_list#5443
sofisl merged 4 commits intomainfrom
update-librarian-config

Conversation

@sofisl
Copy link
Copy Markdown
Contributor

@sofisl sofisl commented Apr 16, 2026

For googleapis/librarian#4298

See googleapis/librarian#5419 as reference for this work

This is PR 2 in this series: googleapis/librarian#4769 (comment)

@sofisl sofisl requested a review from a team as a code owner April 16, 2026 22:58
@sofisl sofisl requested a review from JoeWang1127 April 16, 2026 22:58
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.73%. Comparing base (7903bbc) to head (378d64f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5443   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files         217      217           
  Lines       48177    48177           
=======================================
  Hits        47087    47087           
  Misses       1090     1090           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan
Copy link
Copy Markdown
Contributor

coryan commented Apr 16, 2026

In case the CI failures are hard to grok or access: we run librarian tidy as part of the CI, and it is printing:


2026/04/16 23:04:11 librarian: yaml: unmarshal errors:
--
  | line 805: cannot unmarshal !!seq into string
  | line 1495: cannot unmarshal !!seq into string
  | line 1683: cannot unmarshal !!seq into string
  | line 1719: cannot unmarshal !!seq into string
  | line 1726: cannot unmarshal !!seq into string
  | line 1732: cannot unmarshal !!seq into string
  | line 1740: cannot unmarshal !!seq into string
  | exit status 1

coryan
coryan previously requested changes Apr 16, 2026
Comment thread librarian.yaml
Comment thread librarian.yaml
Comment thread librarian.yaml
Comment thread librarian.yaml
Comment thread librarian.yaml
@sofisl sofisl force-pushed the update-librarian-config branch from 7e58c8f to e86dbb6 Compare April 16, 2026 23:26
@sofisl sofisl marked this pull request as draft April 16, 2026 23:29
@sofisl sofisl force-pushed the update-librarian-config branch from a30c0ce to d84d184 Compare April 16, 2026 23:29
@sofisl
Copy link
Copy Markdown
Contributor Author

sofisl commented Apr 16, 2026

@dbolduc @coryan it seems like the generated diff is failing because showcase was moved to stable:


diff --git a/src/generated/showcase/.repo-metadata.json b/src/generated/showcase/.repo-metadata.json
--
  | index a20e3a3..6164273 100644
  | --- a/src/generated/showcase/.repo-metadata.json
  | +++ b/src/generated/showcase/.repo-metadata.json
  | @@ -8,6 +8,6 @@
  | "library_type": "GAPIC_AUTO",
  | "name": "showcase",
  | "name_pretty": "Client Libraries Showcase",
  | -    "release_level": "stable",
  | +    "release_level": "preview",
  | "repo": "googleapis/google-cloud-rust"
  | }
  | \ No newline at end of file
  | diff --git a/src/generated/showcase/README.md b/src/generated/showcase/README.md
  | index 4955432..0292796 100644
  | --- a/src/generated/showcase/README.md
  | +++ b/src/generated/showcase/README.md
  | @@ -2,6 +2,14 @@
  |  
  | <!-- Code generated by sidekick. DO NOT EDIT. -->
  |  
  | +**FEEDBACK WANTED:** We believe the APIs in this crate are stable, and
  | +do not anticipate any breaking changes are needed. We are looking for
  | +feedback before labeling the APIs "1.0". Changes (even breaking changes)
  | +are still possible, but not expected.
  | +
  | +We also believe the implementation is ready for production, bugs are
  | +still possible, but not expected.
  | +
  | **WARNING:** some RPCs have no corresponding Rust function to call them.
  | Typically these are streaming RPCs. We expect adding these RPCs in a
  | way that does not break the existing APIs or changes their behavior in a
  | @@ -12,12 +20,6 @@ GitHub repository.
  | Showcase represents both a model API and an integration testing surface for
  | client library generator consumption.
  |  
  | -The client library types and functions are stable and not expected to change.
  | -Please note that Google Cloud services do change from time to time. The client
  | -libraries are designed to preserve backwards compatibility when the service
  | -changes in compatible ways. For example, adding RPCs, or fields to messages
  | -should not introduce breaking changes to the client libraries.
  | -
  | ## Quickstart
  |  
  | The main types to work with this crate are the clients:
  | diff --git a/src/generated/showcase/src/lib.rs b/src/generated/showcase/src/lib.rs
  | index 639a423..b4fea17 100644
  | --- a/src/generated/showcase/src/lib.rs
  | +++ b/src/generated/showcase/src/lib.rs
  | @@ -16,6 +16,14 @@
  |  
  | //! Google Cloud Client Libraries for Rust - Client Libraries Showcase API
  | //!
  | +//! **FEEDBACK WANTED:** We believe the APIs in this crate are stable, and
  | +//! do not anticipate any breaking changes are needed. We are looking for
  | +//! feedback before labeling the APIs "1.0". Changes (even breaking changes)
  | +//! are still possible, but not expected.
  | +//!
  | +//! We also believe the implementation is ready for production, bugs are
  | +//! still possible, but not expected.
  | +//!
  | //! **WARNING:** some RPCs have no corresponding Rust function to call them.
  | //! Typically these are streaming RPCs. We expect adding these RPCs in a
  | //! way that does not break the existing APIs or changes their behavior in a
  | @@ -26,12 +34,6 @@
  | //! This crate contains traits, types, and functions to interact with Client Libraries Showcase API
  | //! Most applications will use the structs defined in the [client] module.
  | //!
  | -//! The client library types and functions are stable and not expected to change.
  | -//! Please note that Google Cloud services do change from time to time. The client
  | -//! libraries are designed to preserve backwards compatibility when the service
  | -//! changes in compatible ways. For example, adding RPCs, or fields to messages
  | -//! should not introduce breaking changes to the client libraries.
  | -//!
  | //! # Available Clients
  | //!
  | //! * [Compliance](client/struct.Compliance.html)


<br class="Apple-interchange-newline">

This seems unrelated to my change but I can check to see if there were any expected diffs for Librarian. If that's the case, is the recommended approach to run regenerate? I'll also ask in the Librarian chat to cross-reference.

@dbolduc
Copy link
Copy Markdown
Member

dbolduc commented Apr 17, 2026

@dbolduc @coryan it seems like the generated diff is failing because showcase was moved to stable:

At a guess, it was googleapis/librarian#5276

This seems unrelated to my change but I can check to see if there were any expected diffs for Librarian. If that's the case, is the recommended approach to run regenerate? I'll also ask in the Librarian chat to cross-reference.

Yeah, we should regenerate. This is the safe way:

https://github.com/googleapis/google-cloud-rust/blob/main/doc/contributor/howto-guide-generated-code-maintenance.md#all-libraries

But if you want to YOLO showcase only, you can do:

V=$(sed -n 's/^version: *//p' librarian.yaml)
go run github.com/googleapis/librarian/cmd/librarian@${V} generate google-cloud-showcase-v1beta1

@dbolduc
Copy link
Copy Markdown
Member

dbolduc commented Apr 17, 2026

If we wanted to be super proper, we would send one PR updating librarian to a commit that flips showcase from stable to preview and merge that, then send this PR.... but mehhh who has time for that.

@dbolduc
Copy link
Copy Markdown
Member

dbolduc commented Apr 17, 2026

but mehhh who has time for that.

Me, apparently. I just sent #5445. We should merge that then rebase this PR.

@sofisl
Copy link
Copy Markdown
Contributor Author

sofisl commented Apr 17, 2026

@dbolduc thank you so much for your help and all the PRs!! Appreciate it, especially since I'm ramping up on Librarian and Rust. :)

@sofisl sofisl requested a review from coryan April 17, 2026 19:28
@coryan coryan dismissed their stale review April 17, 2026 19:28

No longer relevant.

@dbolduc
Copy link
Copy Markdown
Member

dbolduc commented Apr 17, 2026

@dbolduc thank you so much for your help and all the PRs!! Appreciate it, especially since I'm ramping up on Librarian and Rust. :)

No problem, thanks for the update!

@sofisl sofisl marked this pull request as ready for review April 17, 2026 20:02
@sofisl sofisl merged commit 2de5e93 into main Apr 17, 2026
35 checks passed
@sofisl sofisl deleted the update-librarian-config branch April 17, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants