Skip to content

feat(pubsub): retry confirmed_ack partial failures in Subscriber#5431

Merged
PhongChuong merged 5 commits intogoogleapis:mainfrom
PhongChuong:subRetryPolicy
Apr 17, 2026
Merged

feat(pubsub): retry confirmed_ack partial failures in Subscriber#5431
PhongChuong merged 5 commits intogoogleapis:mainfrom
PhongChuong:subRetryPolicy

Conversation

@PhongChuong
Copy link
Copy Markdown
Contributor

Towards #4804

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Apr 16, 2026
Comment thread src/pubsub/src/subscriber/retry_policy.rs
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 95.88235% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.64%. Comparing base (52388cc) to head (4678b4b).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/pubsub/src/subscriber/retry_policy.rs 90.76% 6 Missing ⚠️
src/pubsub/src/subscriber/leaser.rs 99.04% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5431      +/-   ##
==========================================
- Coverage   97.66%   97.64%   -0.03%     
==========================================
  Files         216      216              
  Lines       47592    47746     +154     
==========================================
+ Hits        46481    46620     +139     
- Misses       1111     1126      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PhongChuong PhongChuong marked this pull request as ready for review April 16, 2026 17:01
@PhongChuong PhongChuong requested a review from a team as a code owner April 16, 2026 17:01
Comment thread src/pubsub/src/subscriber/leaser.rs Outdated
Comment thread src/pubsub/src/subscriber/retry_policy.rs Outdated
Comment thread src/pubsub/src/subscriber/leaser.rs
Comment thread src/pubsub/src/subscriber/leaser.rs Outdated
Comment thread src/pubsub/src/subscriber/leaser.rs Outdated
Comment thread src/pubsub/src/subscriber/retry_policy.rs
Comment thread src/pubsub/src/subscriber/retry_policy.rs Outdated
Comment thread src/pubsub/src/subscriber/leaser.rs
Comment thread src/pubsub/src/subscriber/leaser.rs
@PhongChuong PhongChuong merged commit 7903bbc into googleapis:main Apr 17, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants