Skip to content

feat: enable mypy session for ndb #16691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chalmerlowe merged 9 commits into from
Apr 21, 2026
Merged

feat: enable mypy session for ndb #16691

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
990f5a9
feat: enable mypy session for ndb
chalmerlowe Apr 16, 2026
d4f5310
feat(ndb): enable mypy and resolve type errors
chalmerlowe Apr 17, 2026
9934515
fix(ndb): fix python 3.9 compatibility and __all__ test failures
chalmerlowe Apr 17, 2026
ec2312c
fix(ndb): fix mypy errors and undefined Any name
chalmerlowe Apr 17, 2026
a316b6f
fix(ndb): replace asserts in production code with explicit checks
chalmerlowe Apr 17, 2026
51c6e18
adds comment about the transition from context to ctx
chalmerlowe Apr 17, 2026
787e904
style: blacken ndb/model.py
chalmerlowe Apr 17, 2026
4f9468d
style: blacken ndb/context.py
chalmerlowe Apr 17, 2026
0ee10cc
Update temp variable name from st to parsed_time
chalmerlowe Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions packages/google-cloud-ndb/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,10 +453,20 @@ def core_deps_from_source(session):
@nox.session(python=DEFAULT_INTERPRETER)
def mypy(session):
"""Run the type checker."""

# TODO(https://github.com/googleapis/google-cloud-python/issues/16014):
# Enable mypy once this bug is fixed.
session.skip("Temporarily skip mypy. See issue 16014")
session.install(
"mypy<1.16.0",
"types-requests",
"types-protobuf",
)
session.install("-e", ".")
session.run(
"mypy",
"-p",
"google.cloud.ndb",
"--check-untyped-defs",
"--ignore-missing-imports",
*session.posargs,
)
Comment thread
chalmerlowe marked this conversation as resolved.


@nox.session(python=DEFAULT_INTERPRETER)
Expand Down
Loading