Skip to content

Use gradle model to find the Configuration associated with a SourceSet #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmini wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use gradle model to find the Configuration associated with a SourceSet #778

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
161f5a0
Use gradle model to find the Configuration associated with a SourceSet
jmini Apr 10, 2025
5cc44e7
Use JavaPluginExtension to access sourceSet
jmini Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/main/groovy/com/google/protobuf/gradle/ProtobufPlugin.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ import org.gradle.api.file.FileCollection
import org.gradle.api.file.SourceDirectorySet
import org.gradle.api.internal.artifacts.ArtifactAttributes
import org.gradle.api.plugins.AppliedPlugin
import org.gradle.api.plugins.JavaPluginExtension
import org.gradle.api.provider.Provider
import org.gradle.api.tasks.SourceSet
import org.gradle.language.jvm.tasks.ProcessResources
Expand Down Expand Up @@ -192,10 +193,12 @@ class ProtobufPlugin implements Plugin<Project> {
*/
private Configuration createCompileProtoPathConfiguration(ProtoSourceSet protoSourceSet) {
String compileProtoConfigName = Utils.getConfigName(protoSourceSet.name, 'compileProtoPath')
JavaPluginExtension javaExtension = project.getExtensions().getByType(JavaPluginExtension.class);
SourceSet sourceSet = javaExtension.getSourceSets().getByName(protoSourceSet.name)
Configuration compileConfig =
project.configurations.getByName(Utils.getConfigName(protoSourceSet.name, 'compileOnly'))
project.configurations.getByName(sourceSet.getCompileOnlyConfigurationName())
Configuration implementationConfig =
project.configurations.getByName(Utils.getConfigName(protoSourceSet.name, 'implementation'))
project.configurations.getByName(sourceSet.getImplementationConfigurationName())
return project.configurations.create(compileProtoConfigName) { Configuration it ->
it.visible = false
it.transitive = true
Expand Down